8000 Fix inconsistencies by AdamRJensen · Pull Request #1268 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]

Skip to content

Fix inconsistencies #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Aug 9, 2021
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
d7deb80
Add cams.get_cams_radiation function
Feb 22, 2021
510f08e
Revert "Add cams.get_cams_radiation function"
Feb 22, 2021
8132943
Fix inconsistencies
AdamRJensen Jul 30, 2021
a93f38a
Merge branch 'master' into pvlib_inconsistencies
AdamRJensen Jul 30, 2021
95c029e
Merge remote-tracking branch 'upstream/master' into pvlib_inconsisten…
AdamRJensen Jul 30, 2021
1a10c67
Merge remote-tracking branch 'upstream/master' into pvlib_inconsisten…
AdamRJensen Jul 30, 2021
95efd76
Have station arg precede start/end in get_bsrn
AdamRJensen Jul 30, 2021
f4c2576
Update get_bsrn doc string
AdamRJensen Jul 30, 2021
082c3f8
Change output order in psm3
AdamRJensen Jul 30, 2021
b8bdd62
Add variable map to pvgis_tmy with depreciating warning
AdamRJensen Aug 2, 2021
b659af2
Add variable_map to pvgis_tmy
AdamRJensen Aug 2, 2021
146a8b5
Coverage for variable_map for read_pvigs_tmy
AdamRJensen Aug 2, 2021
2ac6185
Add "versionchanged" to psm3 docs
AdamRJensen Aug 2, 2021
5303e08
Update psm3 docs
AdamRJensen Aug 2, 2021
941eb30
8000 Update versionchanged
AdamRJensen Aug 2, 2021
ab4ac23
Update versionchange message
AdamRJensen Aug 3, 2021
b4a5228
Correct ouput for get_pvgis_tmy with epw format
AdamRJensen Aug 4, 2021
dbee07e
Update pvgis_tmy map test
AdamRJensen Aug 4, 2021
42db488
Update v0.9.0.rst
AdamRJensen Aug 4, 2021
58242b5
Implement comments from review by kanderso-nrel
AdamRJensen Aug 5, 2021
7f3b32c
Remove 'empty' columns when an empty dataframe is returned by bsrn
AdamRJensen Aug 5, 2021
d67a1e9
Remove admonition about pvgis renaming in introtutorial.rst
AdamRJensen Aug 5, 2021
d9bc9cb
Fix typo in pvigs_tmy documentation
AdamRJensen Aug 5, 2021
162cd2f
Fix references in whatsnew
AdamRJensen Aug 5, 2021
ecc549a
Refactor pvigs_tmy
AdamRJensen Aug 6, 2021
9cb3602
Fix stickler
AdamRJensen Aug 6, 2021
0b6ccb5
Fix issue references in whatsnew
AdamRJensen Aug 6, 2021
aedc064
Coverage for get_pvgis_tmy map_variables
AdamRJensen Aug 6, 2021
7dd2c3c
Fix errors in whatsnew
AdamRJensen Aug 6, 2021
6d1045c
Add double backticks in whatsnew
AdamRJensen Aug 9, 2021
01f5d3c
Add double backticks in whatsnew
AdamRJensen Aug 9, 2021
381870f
Add double backticks in whatsnew
AdamRJensen Aug 9, 2021
17f9138
Add double backticks in whatsnew
AdamRJensen Aug 9, 2021
c8e5a6a
Change fail version to 0.10 in test_modelchain
AdamRJensen Aug 9, 2021
8c77b65
Coverage for deprecation warnings
AdamRJensen Aug 9, 2021
351f549
Fix doublebackticks in whatsnew
AdamRJensen Aug 9, 2021
0aee6a8
Fix stickler
AdamRJensen Aug 9, 2021
6276ccc
Replace tab with spaces in introtutorial
AdamRJensen Aug 9, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
8000
Diff view
Prev Previous commit
Next Next commit
Coverage for deprecation warnings
  • Loading branch information
AdamRJensen committed Aug 9, 2021
commit 8c77b65c5667bf23a80ab7c82f87cf8ca0a76fea
15 changes: 14 additions & 1 deletion pvlib/tests/iotools/test_pvgis.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@
import requests
from pvlib.iotools import get_pvgis_tmy, read_pvgis_tmy
from pvlib.iotools import get_pvgis_hourly, read_pvgis_hourly
from ..conftest import DATA_DIR, RERUNS, RERUNS_DELAY, assert_frame_equal
from ..conftest import (DATA_DIR, RERUNS, RERUNS_DELAY, assert_frame_equal,
fail_on_pvlib_version)
from pvlib._deprecation import pvlibDeprecationWarning


# PVGIS Hourly tests
Expand Down Expand Up @@ -362,6 +364,17 @@ def pvgis_tmy_mapped_columns():
'wind_speed', 'wind_direction', 'pressure']


@fail_on_pvlib_version('0.10')
@pytest.mark.remote_data
@pytest.mark.flaky(reruns=RERUNS, reruns_delay=RERUNS_DELAY)
def test_pvgis_tmy_variable_map_deprecating_warning_0_10():
with pytest.warns(pvlibDeprecationWarning, match='names will be renamed'):
_ = get_pvgis_tmy(45, 8)
with pytest.warns(pvlibDeprecationWarning, match='names will be renamed'):
fn = DATA_DIR / 'tmy_45.000_8.000_2005_2016.epw'
_ = read_pvgis_tmy(fn)


@pytest.mark.remote_data
@pytest.mark.flaky(reruns=RERUNS, reruns_delay=RERUNS_DELAY)
def test_get_pvgis_tmy(expected, month_year_expected, inputs_expected,
Expand Down
0