8000 Update irradiance.aoi to use more reliable formula by kandersolar · Pull Request #1191 · pvlib/pvlib-python · GitHub
[go: up one dir, main page]
Skip to content

Update irradiance.aoi to use more reliable formula #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 14, 2021
+26 −0
Merged

Update irradiance.aoi to use more reliable formula #1191

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8069470
clip to [-1, 1]
kandersolar Mar 10, 2021
e0e7d99
add test
kandersolar Mar 10, 2021
2a0425b
whatsnew
kandersolar Mar 10, 2021
3ee6418
use new aoi formula
kandersolar Mar 13, 2021
8fb5070
revert changes to aoi_projection
kandersolar Mar 13, 2021
30cb9f2
update test and whatsnew
kandersolar Mar 13, 2021
671cf16
don't set name; break after first Series
kandersolar Mar 17, 2021
c2e6471
roll back to 2a0425b
kandersolar May 14, 2021
669483d
Merge remote-tracking branch 'upstream/master' into aoi_projection_clamp
kandersolar May 14, 2021
ab7b57d
test improvements
kandersolar May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't set name; break after first Series
  • Loading branch information
@kandersolar
kandersolar committed Mar 17, 2021
commit 671cf1649ae8a123e2c640fa2cddbae728b3a482
2 changes: 1 addition & 1 deletion pvlib/irradiance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def aoi(surface_tilt, surface_azimuth, solar_zenith, solar_azimuth):
for arg in [surface_tilt, surface_azimuth, solar_zenith, solar_azimuth]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK to assume that these Series have a common index, and stop the loop when one index if found.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the new implementation preserve Series in --> Series out without this code?

I'm fine with dropping the name assignment and letting users deal with that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the new implementation preserve Series in --> Series out without this code?

Unfortunately it does not; the _spherical_to_cartesian function turns Series into 2-D numpy arrays. I don't immediately see a way around it that's cleaner than the "fix types at the end" idiom.

if hasattr(arg, 'index'):
aoi_value = pd.Series(aoi_value, index=arg.index)
aoi_value.name = 'aoi'
break

return aoi_value

Expand Down
0