add scale_voltage_current_power to ModelChain.pvwatts_dc, docstring e…

…dits, whatsnew
pvlib · wholmgren · Jan 21, 2021 · Jan 20, 2021 · Jan 20, 2021 · Jan 21, 2021
commit d210be90b48b886c44277d4b3abdfb508fae1360
diff --git a/docs/sphinx/source/whatsnew/v0.9.0.rst b/docs/sphinx/source/whatsnew/v0.9.0.rst
@@ -83,6 +83,10 @@ Enhancements
   automatically switch to using ``'effective_irradiance'`` (if available) for
   cell temperature models, when ``'poa_global'`` is not provided in input
   weather or calculated from input weather data.
+* :py:meth:`~pvlib.modelchain.ModelChain.pvwatts_dc` now scales the DC power
+  by `pvsystem.PVSystem.modules_per_strings` and
+  `pvsystem.PVSystem.strings_per_inverter`. Note that both attributes still
+  default to 1. (:pull:`XXXX`)
 
 Bug fixes
 ~~~~~~~~~

diff --git a/pvlib/modelchain.py b/pvlib/modelchain.py
@@ -730,8 +730,27 @@ def pvsyst(self):
         return self._singlediode(self.system.calcparams_pvsyst)
 
     def pvwatts_dc(self):
+        """Calculate DC power using the PVWatts model.
+
+        Results are stored in ModelChain.results.dc. DC power is computed
+        from PVSystem.module_parameters['pdc0'] and then scaled by
+        PVSystem.modules_per_string and PVSystem.strings_per_inverter.
+
+        Returns
+        -------
+        self
+
+        See also
+        --------
+        pvlib.pvsystem.PVSystem.pvwatts_dc
+        pvlib.pvsystem.PVSystem.scale_voltage_current_power
+        """
         self.results.dc = self.system.pvwatts_dc(
             self.results.effective_irradiance, self.results.cell_temperature)
+        self.results.dc = self.system.scale_voltage_current_power(
+            self.results.dc,
+            unwrap=False
+        )
         return self
 
     @property

diff --git a/pvlib/pvsystem.py b/pvlib/pvsystem.py
@@ -2675,20 +2675,20 @@ def pvwatts_dc(g_poa_effective, temp_cell, pdc0, gamma_pdc, temp_ref=25.):
     Parameters
     ----------
     g_poa_effective: numeric
-        Irradiance transmitted to the PV cells in units of W/m**2. To be
+        Irradiance transmitted to the PV cells. To be
         fully consistent with PVWatts, the user must have already
         applied angle of incidence losses, but not soiling, spectral,
-        etc.
+        etc. [W/m^2]
     temp_cell: numeric
-        Cell temperature in degrees C.
+        Cell temperature [C].
     pdc0: numeric
-        Power of the modules at 1000 W/m2 and cell reference temperature.
+        Power of the modules at 1000 W/m^2 and cell reference temperature. [W]
     gamma_pdc: numeric
-        The temperature coefficient in units of 1/C. Typically -0.002 to
-        -0.005 per degree C.
+        The temperature coefficient of power. Typically -0.002 to
+        -0.005 per degree C. [1/C]
     temp_ref: numeric, default 25.0
         Cell reference temperature. PVWatts defines it to be 25 C and
-        is included here for flexibility.
+        is included here for flexibility. [C]
 
     Returns
     -------

diff --git a/pvlib/tests/test_modelchain.py b/pvlib/tests/test_modelchain.py
@@ -1180,6 +1180,23 @@ def test_dc_model_user_func(pvwatts_dc_pvwatts_ac_system, location, weather,
     assert not mc.results.ac.empty
 
 
+def test_pvwatts_dc_multiple_strings(pvwatts_dc_pvwatts_ac_system, location,
+                                     weather, mocker):
+    system = pvwatts_dc_pvwatts_ac_system.copy()
+    system.modules_per_string = 2
+    m = mocker.spy(system, 'scale_voltage_current_power')
+    mc1 = ModelChain(pvwatts_dc_pvwatts_ac_system, location,
+                     aoi_model='no_loss', spectral_model='no_loss')
+    mc1.run_model(weather)
+    mc2 = ModelChain(system, location,
+                     aoi_model='no_loss', spectral_model='no_loss')
+    mc2.run_model(weather)
+    assert m.call_count == 1
+    assert isinstance(mc2.results.ac, (pd.Series, pd.DataFrame))
+    assert not mc2.results.ac.empty
+    assert np.isclose(mc2.results.dc / mc1.results.dc, 2.0)
+
+
 def acdc(mc):
     mc.results.ac = mc.results.dc