MAINT Remove deprecated support for int in boolean constraint (scikit-learn#27924)

thomasjpfan · web-flow · commit 0496f4877c2e · 2023-12-11T11:17:05.000+01:00
diff --git a/sklearn/utils/_param_validation.py b/sklearn/utils/_param_validation.py
@@ -2,7 +2,6 @@
 import math
 import operator
 import re
-import warnings
 from abc import ABC, abstractmethod
 from collections.abc import Iterable
 from inspect import signature
@@ -587,20 +586,9 @@ def __init__(self):
         self._constraints = [
             _InstancesOf(bool),
             _InstancesOf(np.bool_),
-            _InstancesOf(Integral),
         ]
 
     def is_satisfied_by(self, val):
-        # TODO(1.4) remove support for Integral.
-        if isinstance(val, Integral) and not isinstance(val, bool):
-            warnings.warn(
-                (
-                    "Passing an int for a boolean parameter is deprecated in version"
-                    " 1.2 and won't be supported anymore in version 1.4."
-                ),
-                FutureWarning,
-            )
-
         return any(c.is_satisfied_by(val) for c in self._constraints)
 
     def __str__(self):
diff --git a/sklearn/utils/tests/test_param_validation.py b/sklearn/utils/tests/test_param_validation.py
@@ -627,12 +627,6 @@ def f(param):
     f(True)
     f(np.bool_(False))
 
-    # an int is also valid but deprecated
-    with pytest.warns(
-        FutureWarning, match="Passing an int for a boolean parameter is deprecated"
-    ):
-        f(1)
-
 
 def test_no_validation():
     """Check that validation can be skipped for a parameter."""
