8000 Verilator compile fixes by solomatnikov · Pull Request #255 · pulp-platform/common_cells · GitHub
[go: up one dir, main page]
Skip to content

Verilator compile fixes #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

Verilator compile fixes #255

merged 1 commit into from
May 8, 2025

Conversation

solomatnikov
Copy link
Contributor
@solomatnikov solomatnikov commented May 5, 2025 •
edited
Loading

@solomatnikov solomatnikov force-pushed the verilator_compile_fixes branch from 3dd7324 to 97f366d Compare May 5, 2025 05:52
@niwis niwis requested review from phsauter and niwis May 6, 2025 13:57
niwis
niwis approved these changes May 8, 2025
View reviewed changes
Copy link
Collaborator
@niwis niwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a lot @solomatnikov, especially for linking the Verilator issues! LGTM.

@niwis niwis merged commit 47b020a into pulp-platform:master May 8, 2025
5 checks passed
@solomatnikov
Copy link
Contributor Author

verilator/verilator#5265 (comment)

@solomatnikov solomatnikov mentioned this pull request May 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niwis niwis niwis approved these changes

@phsauter phsauter Awaiting requested review from phsauter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solomatnikov @niwis
0