Update to protobuf 30.1 and drop bazel workspace configuration #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proto descriptor API has changed to return absl::string_views instead of std::string, which is preventing users from building at HEAD. This change bumps our dependency to protobuf 30.1 and migrates our code generator as needed so we can build with absl::string_view values. At the same time, Bazel is getting ready to drop workspace support (disabled by default as of EOY2024/Bazel 8). Protobuf still seems to support both, but opportunistically taking this opportunity to just use Bazel models. We can temporarily add back workspace support if users actually need it.
lukesandberg
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proto descriptor API has changed to return absl::string_views instead of std::string, which is preventing users from building at HEAD.
This change bumps our dependency to protobuf 30.1 and migrates our code generator as needed so we can build with absl::string_view values.
At the same time, Bazel is getting ready to drop workspace support (disabled by default as of EOY2024/Bazel 8). Protobuf still seems to support both, but opportunistically taking this opportunity to just use Bazel models. We can temporarily add back workspace support if users actually need it.