Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 11 commits
- 19 files changed
- 4 contributors
Commits on Jul 16, 2024
-
Port fix: Fix JSPB binary utf8 decoding to be spec compliant.
Our prior behavior was extremely undefined when confronted with errors, it would read out of bounds, accept overlong encodings, skip over out of range bytes, compose out of range codepoints. The new implementation always detects and handles errors consistently by either throwing or using replacement characters (� aka \uFFFD) This also adds support for aligning with the proto3 spec to the code generator which requires that parsing fail for proto3 messages with invalid utf8 payloads for string fields. For now, actual failing is disabled via the goog.define jspb.binary.ENFORCE_UTF8 which is set to NEVER. A future change will flip this to DEFAULT.
-
Co-authored-by: Luke Sandberg <lukesandberg@users.noreply.github.com>
-
Fix build errors from utf8 enforcement changes
This change fixes some minor build issues from not using fully specified function names. There was also a missing parameter issue for BinaryDecoder.readStringWithLength's invocation of readString, but the former appears to be dead code so just removed it.
Commits on Jul 18, 2024
-
Specify os and cpu for release name to avoid duplicates
actions/upload-artifact@4 made a breaking change to fail on duplicate names. I think we are seeing Windows release errors as a result since both x64_x86 and x64 are named 'releases'. This change just tags the os and cpu onto the release dir name to reflect the specific build.
Commits on Sep 12, 2024
-
Bump micromatch from 4.0.7 to 4.0.8
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.7 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.7...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Commits on Sep 17, 2024
Commits on Mar 17, 2025
-
Update to protobuf 30.1 and drop bazel workspace configuration
The proto descriptor API has changed to return absl::string_views instead of std::string, which is preventing users from building at HEAD. This change bumps our dependency to protobuf 30.1 and migrates our code generator as needed so we can build with absl::string_view values. At the same time, Bazel is getting ready to drop workspace support (disabled by default as of EOY2024/Bazel 8). Protobuf still seems to support both, but opportunistically taking this opportunity to just use Bazel models. We can temporarily add back workspace support if users actually need it.
-
Merge pull request #229 from dibenede/update-protobuf
Update to protobuf 30.1 and drop bazel workspace configuration
Commits on Mar 19, 2025
-
This file was generated by re-running the actions marketplace installation. Cleaning up the old scorecards.yml that is obsoleted by this new file.
-
Fix path for rules_pkg providers.bzl load
We use PackageVariablesInfo from rules_pkg for versioning. The previous change bumped the version of our rules_pkg dependency and it looks like that moved the declaring providers.bzl file change to a `pkg/` subdir. This broke our Windows builds/release automation since they use //:dist_zip. We did not catch this during PR testing because we just do `npm test`.
Commits on May 15, 2025
-
Protobuf 31 contains field descriptor API changes for optional-ness. This change adjusts to the suggested !required && !repeated.
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.21.4...main