8000 Required a minimum of C++17 in CMake project by cyyever · Pull Request #21803 · protocolbuffers/protobuf · GitHub
[go: up one dir, main page]
Skip to content

Required a minimum of C++17 in CMake project #21803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Required a minimum of C++17 in CMake project #21803

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Contributor
@cyyever cyyever commented May 17, 2025

No description provided.

@mkruskal-google
Copy link
Member
mkruskal-google commented May 19, 2025 •
edited
Loading

IIUC this will force all downstream projects that include our cmake config to C++17, which is not what we want. We support a minimum of C++17, and AFAIK CMake doesn't support specifying a constraint like that

@mkruskal-google mkruskal-google self-assigned this May 19, 2025
@cyyever
Copy link
Contributor Author
cyyever commented May 19, 2025 •
edited
Loading

@mkruskal-google Fixed it by defaulting to 17.

@cyyever cyyever force-pushed the cxx17 branch 2 times, most recently from 1fd07b1 to 656124f Compare May 20, 2025 00:49
@mkruskal-google
Copy link
Member

hmm I guess that works, thanks!

mkruskal-google
mkruskal-google reviewed May 20, 2025
View reviewed changes
@mkruskal-google mkruskal-google changed the title Enable C++17 on all platforms Default to C++17 on all platforms May 20, 2025
mkruskal-google
mkruskal-google reviewed May 20, 2025
View reviewed changes
mkruskal-google
mkruskal-google reviewed May 20, 2025
View reviewed changes
@cyyever cyyever force-pushed the cxx17 branch 2 times, most recently from a61191f to 3075b5a Compare May 20, 2025 02:31
< 8000 /div>
@cyyever
Copy link
Contributor Author
cyyever commented May 20, 2025

@mkruskal-google Now only libprotobuf* is guaranteed C++17.

@cyyever cyyever changed the title Default to C++17 on all platforms Default to C++17 for protobuf targets May 20, 2025
@cyyever cyyever requested a review from mkruskal-google May 20, 2025 02:39
@cyyever cyyever force-pushed the cxx17 branch 3 times, most recently from 9a2308f to b8f7a4b Compare May 20, 2025 03:04
mkruskal-google
mkruskal-google reviewed May 20, 2025
View reviewed changes
@cyyever cyyever force-pushed the cxx17 branch 2 times, most recently from ca94a4c to 308dcaa Compare May 20, 2025 03:24
@cyyever
Enable C++17 on all platforms
fb7e266 
Signed-off-by: cyy <cyyever@outlook.com>
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 20, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 20, 2025
mkruskal-google
mkruskal-google reviewed May 20, 2025
View reviewed changes
@cyyever cyyever requested a review from mkruskal-google May 20, 2025 04:33
@mkruskal-google mkruskal-google changed the title Default to C++17 for protobuf targets Required a minimum of C++17 in CMake project May 20, 2025
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 20, 2025
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label May 20, 2025
@mkruskal-google
Copy link
Member

Thanks for the contribution and iteration!

@cyyever cyyever deleted the cxx17 branch May 21, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkruskal-google mkruskal-google mkruskal-google approved these changes

Assignees

@mkruskal-google mkruskal-google

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyyever @mkruskal-google
0