Allow nested scrolling of Windows #1701
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1796a3 to
e6aed39
Compare
|
I don't think the test failures are related to the proposed changes |
These changes mean that Windows will return NotImplemented when attempting to scroll beyond their scrollable limits, allowing mouse scroll events to bubble up to a parent container when a window in a scrollable container is scrolled.
e6aed39 to
f5a9d1f
Compare
|
I've rebased and fixed the issues with checks. This would also allow implementing a wrapping Screencast_20240117_193406-1.webm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes mean that Windows will return
NotImplementedwhen attempting to scroll beyond their scrollable limits.This means mouse scroll events can bubble up to a scrollable parent container when a window has finished scrolling.
In the following screen recording, you can see that when the
TextAreamoves under the mouse while scrolling the parent pane, it begins scrolling, and when theTextAreahas scrolled all the way to the bottom, the parent pane resumes scrolling:nested-scrolling.webm
I've also changed the reported line-count of the
DummyControlto1rather than100*100for this to work. Without this, Windows without content believe theirDummyControlis always scrollable and accept all scroll events. I can't find any issues with doing this - why was theDummyControl's content's line count set to100*100?