8000 feat: Remove binding from Probe's status when workload deletd or invalid Ref by dongjiang1989 · Pull Request #7980 · prometheus-operator/prometheus-operator · GitHub
[go: up one dir, main page]
Skip to content

feat: Remove binding from Probe's status when workload deletd or invalid Ref #7980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2025
Merged

feat: Remove binding from Probe's status when workload deletd or invalid Ref #7980

merged 3 commits into from
Oct 6, 2025

Conversation

dongjiang1989
Copy link
Member

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

If it fixes an existing issue (bug or feature), use the following keyword:

Closes: #7928

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

Remove binding from Probe's status when workload deletd or invalid Ref

@dongjiang1989
Remove binding from Probe's status when workload deletd or invalid Ref
1618fcc 
Signed-off-by: dongjiang <dongjiang1989@126.com>
@dongjiang1989 dongjiang1989 marked this pull request as ready for review October 5, 2025 10:06
@dongjiang1989 dongjiang1989 requested a review from a team as a code owner October 5, 2025 10:06
@dongjiang1989
update cleanup
ee37748 
Signed-off-by: dongjiang <dongjiang1989@126.com>
@dongjiang1989
update docs
d4d59c1 
Signed-off-by: dongjiang <dongjiang1989@126.com>
@dongjiang1989
Copy link
Member Author

cc @yp969803
8000

@dongjiang1989 dongjiang1989 requested a review from yp969803 October 5, 2025 10:56
@yp969803
Copy link
Contributor
yp969803 commented Oct 5, 2025

/lgtm

@yp969803
Copy link
Contributor
yp969803 commented Oct 6, 2025

@simonpasquier merge request

simonpasquier
simonpasquier reviewed Oct 6, 2025
View reviewed changes
Copy link
Contributor
@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@simonpasquier simonpasquier merged commit 1936e40 into prometheus-operator:main Oct 6, 2025
22 checks passed
@dongjiang1989 dongjiang1989 deleted the issue-7928 branch October 7, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier approved these changes

@yp969803 yp969803 Awaiting requested review from yp969803

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove binding from Probe's status subresource when Prometheus gets deleted
3 participants
@dongjiang1989 @yp969803 @simonpasquier
0