-
Notifications
You must be signed in to change notification settings - Fork 3.8k
change: remove feature flag metadata-wal-records
when prometheus version higher the 3.4
#7893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: remove feature flag metadata-wal-records
when prometheus version higher the 3.4
#7893
Conversation
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can we add a comment explaining that the metadata-wal-records
feature flag isn't mandatory starting with Prometheus v3.4.0?
added a small comment with link to the issue. pls review. |
Co-authored-by: Simon Pasquier <spasquie@redhat.com>
Co-authored-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
8e6f399
into
prometheus-operator:main
metadata-wal-records
when prometheus version higher the 3.4metadata-wal-records
when prometheus version higher the 3.4
metadata-wal-records
when prometheus version higher the 3.4metadata-wal-records
when prometheus version higher the 3.4
Description
From issue #7889
CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.