8000 change: remove feature flag `metadata-wal-records` when prometheus version higher the 3.4 by heliapb · Pull Request #7893 · prometheus-operator/prometheus-operator · GitHub
[go: up one dir, main page]

Skip to content

Conversation

heliapb
Copy link
Member
@heliapb heliapb commented Sep 9, 2025

Description

From issue #7889

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.


Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
@heliapb heliapb marked this pull request as ready for review September 9, 2025 14:42
@heliapb heliapb requested a review from a team as a code owner September 9, 2025 14:42
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Sep 9, 2025
@heliapb heliapb closed this Sep 9, 2025
@heliapb heliapb reopened this Sep 9, 2025
Copy link
Contributor
@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we add a comment explaining that the metadata-wal-records feature flag isn't mandatory starting with Prometheus v3.4.0?

Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
@heliapb
Copy link
Member Author
heliapb commented Sep 10, 2025

LGTM! Can we add a comment explaining that the metadata-wal-records feature flag isn't mandatory starting with Prometheus v3.4.0?

added a small comment with link to the issue. pls review.

heliapb and others added 3 commits September 10, 2025 13:33
Co-authored-by: Simon Pasquier <spasquie@redhat.com>
Co-authored-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Hélia Barroso <helia_barroso@hotmail.com>
@simonpasquier simonpasquier merged commit 8e6f399 into prometheus-operator:main Sep 11, 2025
35 of 37 checks passed
@simonpasquier simonpasquier changed the title fix: feature flag metadata-wal-records when prometheus version higher the 3.4 change: feature flag metadata-wal-records when prometheus version higher the 3.4 Sep 11, 2025
@simonpasquier simonpasquier changed the title change: feature flag metadata-wal-records when prometheus version higher the 3.4 change: remove feature flag metadata-wal-records when prometheus version higher the 3.4 Sep 11, 2025
@heliapb heliapb deleted the fix/metadata_wal_records branch September 11, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0