chore: change the record api to the new events api
#7867
Merged
+34
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dongjiang <dongjiang1989@126.com>
heliapb
approved these changes
Sep 4, 2025
record api to the new events apirecord api to the new events api
Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
pkg/operator/rules.go
Outdated
| "namespace", promRule.Namespace, | ||
| ) | ||
| prs.eventRecorder.Eventf(promRule, v1.EventTypeWarning, "InvalidConfiguration", "PrometheusRule %s was rejected due to invalid configuration: %v", promRule.Name, err) | ||
| prs.eventRecorder.Eventf(promRule, nil, v1.EventTypeWarning, invalidConfiguration, InvalidConfigurationEvent, "PrometheusRule %s was rejected due to invalid configuration: %v", promRule.Name, err) |
There was a problem hiding this comment.
same comment as previously about the related argument. But given that it's not straightforward to inject the workload resource (e.g. Prometheus or ThanosRuler), we can leave this to a follow-up PR.
There was a problem hiding this comment.
Thanks @simonpasquier
I Got it
The Next PR fix it
|
@simonpasquier Please recheck it |
0b53d36 to
a48b1c3
Compare
Signed-off-by: dongjiang <dongjiang1989@126.com>
Signed-off-by: dongjiang <dongjiang1989@126.com>
simonpasquier
added a commit
to simonpasquier/prometheus-operator
that referenced
this pull request
Sep 26, 2025
This is a follow-up of prometheus-operator#7867 which refactors the event handling to always inject the related object. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
5 tasks
simonpasquier
added a commit
that referenced
this pull request
Sep 26, 2025
This is a follow-up of #7867 which refactors the event handling to always inject the related object. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes an existing issue (bug or feature), use the following keyword:
Closes: #ISSUE-NUMBER
This Pull Request migrates from the old events API (
k8s.io/client-go/tools/record) to the new API (k8s.io/client-go/tools/events).Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.