ci(docker): build and publish linux/riscv64 images#3578
Open
benevolentshrine wants to merge 1 commit intoprometheus:masterfrom
Open
ci(docker): build and publish linux/riscv64 images#3578benevolentshrine wants to merge 1 commit intoprometheus:masterfrom
benevolentshrine wants to merge 1 commit intoprometheus:masterfrom
Conversation
Member
|
This needs a DCO sign-off. You can use |
7242104 to
ef9f55d
Compare
Author
|
Hey @SuperQ! All checks are passing including DCO ✅, would love to get your eyes on this when you get a chance. Happy to make any changes if needed! |
SuperQ
requested changes
Mar 10, 2026
Member
There was a problem hiding this comment.
Let's fix the sort order while we're here.
809bf7b to
82617c1
Compare
Member
|
Can you fix the commit history here? |
99dc128 to
662fdd6
Compare
Author
|
Hey @SuperQ! Applied your suggestions and cleaned up the commit history. All checks passing including DCO ✅, ready for your re-review when you get a chance! |
Member
|
Sorry, it looks like the suggestions were not applied correctly and the git history is still incorrect. |
840a004 to
a1cbf81
Compare
Adds riscv64 to DOCKER_ARCHS in Makefile and un-ignores .build/linux-riscv64 in .dockerignore. Fixes prometheus#3311 Signed-off-by: benevolentshrine <proffersor45@gmail.com>
3eeb6de to
d1c11b6
Compare
Author
|
Hey @SuperQ fixed the commit history, only one clean commit now. Ready for re-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds linux/riscv64 support for Docker image builds.
Fixes #3311
Changes
riscv64toDOCKER_ARCHSin Makefile.build/linux-riscv64in .dockerignoreNotes
Previously attempted in #3312 but was closed when the author deleted
their repository. That PR had received LGTM from a member and was
awaiting final review from @SuperQ.