8000 [WIP] Reduce number of allocations in histogram metric by simpl1g · Pull Request #317 · prometheus/client_ruby · GitHub
[go: up one dir, main page]
Skip to content
/ client_ruby Public

[WIP] Reduce number of allocations in histogram metric #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Reduce number of allocations in histogram metric #317

wants to merge 1 commit into from

Conversation

simpl1g
Copy link
Contributor
@simpl1g simpl1g commented Nov 5, 2024

@dmagliola Hi. I'm committing this as WIP so you can compare old and new implementations side by side, maybe you can add some test cases for benchmarks to find problems. If you are ok with changes I will clean up everything. All tests are passing without modifications, I guess nothing will change in logic it self. I haven't touched #get method though, where is it used?

You can find bench results at the end of spec/benchmarks/histogram.rb file. There are some improvements, but I'm not really happy with results. I believe storage should be changed a bit. Current way of storing each :le as separate hash requires a lot of manipulations for #values. Having single hash can be more beneficial, but current store interface does not allow do this.

Instead of

{{l1: '1', le: '1'} => 1, {l1: '1', le: '2'} => 1, {l1: '1', le: 'sum'} => 2}

something like this should be easier to operate

{{l1: '1'} =>  {'1' => 1, '2' => 1, 'sum' => 2}}

@simpl1g
[WIP] Reduce number of allocations in histogram metric
18d156c 
Signed-off-by: Konstantin Ilchenko <k.ilchenko@appodeal.com>
@simpl1g simpl1g force-pushed the histogram-performance branch from 758ebc8 to 18d156c Compare November 5, 2024 15:30
@simpl1g
Copy link
Contributor Author
simpl1g commented Nov 5, 2024

I will also remove viernier profiler, it is for newer versions of ruby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simpl1g
0