8000 Adds support for the WSGI server to read from a different registry by thomasdesr · Pull Request #83 · prometheus/client_python · GitHub
[go: up one dir, main page]
Skip to content

Adds support for the WSGI server to read from a different registry #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2016
Merged

Adds support for the WSGI server to read from a different registry #83

merged 1 commit into from
Jun 10, 2016

Conversation

thomasdesr
Copy link
Contributor

This is just a quick fix to let the bulit-in WSGI server serve a non-default registry

brian-brazil
brian-brazil reviewed Jun 9, 2016
View reviewed changes
prometheus_client/exposition.py
'''Create a WSGI app which serves the metrics from the registry.'''
def make_wsgi_app(registry=None):
'''Create a WSGI app which serves the metrics from a registry.'''
if registry is None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's safe to default to the default registry in the function definition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done :D

@brian-brazil
Copy link
Contributor

Can you squash your commits?

@thomasdesr thomasdesr force-pushed the master branch 2 times, most recently from 729f033 to 5c5d997 Compare June 10, 2016 00:48
@thomasdesr
Copy link
Contributor Author

@brian-brazil Done :D

@brian-brazil brian-brazil merged commit 42671e2 into prometheus:master Jun 10, 2016
@brian-brazil
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasdesr @brian-brazil
0