8000 Document implications of negative observations by beorn7 · Pull Request #658 · prometheus/client_python · GitHub
[go: up one dir, main page]
Skip to content

Document implications of negative observations #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2021
Merged

Document implications of negative observations #658

merged 1 commit into from
May 28, 2021

Conversation

beorn7
Copy link
Member
@beorn7 beorn7 commented May 26, 2021

Fixes #638.

It's of course weird to talk abou negative values of an
"amount". However, for the Gauge, which quite regularly will receive
negative increments, the word "amount" is used, too, so I didn't want
to change it everywhere to "value" or something.

AFAIK the only place where negative values are rejected is indeed the
Counter.

Signed-off-by: beorn7 beorn@grafana.com

@beorn7 beorn7 requested a review from csmarchbanks May 26, 2021 22:01
@beorn7
Document implications of negative observations
13f786a 
Fixes #638.

It's of course weird to talk abou negative values of an
"amount". However, for the Gauge, which quite regularly will receive
negative increments, the word "amount" is used, too, so I didn't want
to change it everywhere to "value" or something.

AFAIK the only place where negative values are rejected is indeed the
Counter.

Signed-off-by: beorn7 <beorn@grafana.com>
csmarchbanks
csmarchbanks approved these changes May 28, 2021
View reviewed changes
Copy link
Member
@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@csmarchbanks csmarchbanks merged commit e18828f into master May 28, 2021
@beorn7 beorn7 deleted the beorn7/doc branch May 28, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csmarchbanks csmarchbanks csmarchbanks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document implications of negative observations for Summaries and Histograms
2 participants
@beorn7 @csmarchbanks
0