Make OM code effectively 100% covered. #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove some dead code. The untaken branches claimed by coverage are due to loops that always iterate at least once, or because state machines only ever have known states. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
9b3afdb to
ee3ca48
Compare
robskillington
added a commit
to prometheus/OpenMetrics
that referenced
this pull request
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove some dead code. The untaken branches claimed by coverage are
due to loops that always iterate at least once, or because state
machines only ever have known states.
@robskillington this is mostly testing the parser implementation, but this caught some missing general cases too.
Signed-off-by: Brian Brazil brian.brazil@robustperception.io