8000 Add lint stage to CI by yzdann · Pull Request #586 · prometheus/client_python · GitHub
[go: up one dir, main page]
Skip to content

Add lint stage to CI #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 5, 2020
Merged

Add lint stage to CI #586

merged 10 commits into from
Oct 5, 2020

Conversation

yzdann
Copy link
Contributor
@yzdann yzdann commented Oct 4, 2020 •
edited
Loading

Related discussion

  • Add lint stage for: flake8 and isort
  • Add E731 to flake8 config in tox.in do not assign a lambda expression, use a def
  • Clean up W504(line break after binary operator), unused imports, reorder imports and fix indentation
  • Remove deprecated sudo keyword from .travis.yml and also add os: linux

@yzdann yzdann changed the title test travis WIP: add lint to travis Oct 4, 2020
@yzdann yzdann changed the title WIP: add lint to travis WIP: add lint to travis ci Oct 4, 2020
yzdann and others added 9 commits October 4, 2020 23:18
@yzdann
Add lint and test stage
e57f20f 
Signed-off-by: yzdann <22779039+yzdann@users.noreply.github.com>
@yzdann
Add E731 to skip do not assign a lambda expression, use a def in flake8
5cf281a 
Signed-off-by: yzdann <22779039+yzdann@users.noreply.github.com>
@yzdann
Fix indentations
8d0509a 
Signed-off-by: yzdann <22779039+yzdann@users.noreply.github.com>
@yzdann
Fix flake8 W504 line break after binary operator
de9a15f 
Signed-off-by: yzdann <22779039+yzdann@users.noreply.github.com>
@yzdann
Remove unused imports and reorder with isort
5eb1314 
Signed-off-by: yzdann <22779039+yzdann@users.noreply.github.com>
@yzdann
Remove deprecated key sudo
dabc536 
Signed-off-by: yzdann <22779039+yzdann@users.noreply.github.com>
@yzdann
Add os to remove info warn in travis-ci
f5c8ef3 
Signed-off-by: yzdann <22779039+yzdann@users.noreply.github.com>
@yzdann
Add isort to tox and CI
e4fa097 
Signed-off-by: yzdann <22779039+yzdann@users.noreply.github.com>
@yzdann
Move flake8 and isort to lint stage with name
5c8a8f1 
Signed-off-by: yzdann <22779039+yzdann@users.noreply.github.com>
@yzdann yzdann changed the title WIP: add lint to travis ci Add lint stage to CI Oct 4, 2020
brian-brazil
brian-brazil reviewed Oct 5, 2020
View reviewed changes
@brian-brazil
Copy link
Contributor

CI is unhappy.

@yzdann yzdann changed the title Add lint stage to CI WIP: Add lint stage to CI Oct 5, 2020
@yzdann
Copy link
Contributor Author
yzdann commented Oct 5, 2020

CI is unhappy.

Changed to WIP again fix and i will mention you again. 🙏

@yzdann
Fix removed import by flake8 and add skip flake8 with noqa
496c6f9 
Signed-off-by: yzdann <22779039+yzdann@users.noreply.github.com>
@brian-brazil brian-brazil merged commit 3889a5d into prometheus:master Oct 5, 2020
@brian-brazil
Copy link
Contributor

Thanks!

@yzdann yzdann changed the title WIP: Add lint stage to CI Add lint stage to CI Oct 5, 2020
@yzdann
Copy link
Contributor Author
yzdann commented Oct 5, 2020

Thanks for your review 👍 .

@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-brazil brian-brazil brian-brazil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yzdann @brian-brazil
0