Several small test fixes #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,7 +28,8 @@ def run(self): | |||
| self.t = ServingThread() | |||
| self.t.start() | |||
|
|
|||
| self.gb = GraphiteBridge(server.server_address, self.registry, _time=FakeTime()) | |||
| address = ('localhost', server.server_address[1]) | |||
There was a problem hiding this comment.
Can you add a comment here so a future Unix-user doesn't undo this?
|
Thanks for all the fixes, can you squash the commits please? |
- Rename test with duplicate name - Fix race condition in test HTTP handler - Add call to end_headers in test HTTP handler - Use localhost when connecting to a local socket, not 0.0.0.0
7718e6c to
7cf945c
Compare
|
All right, commits squashed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brian-brazil: This bundles together a few small fixes for the tests. Please let me know if you would prefer them as separate pull requests.
test_client.pycontained two tests with the same name (test_pushadd_with_groupingkey), so I renamed the second one to the more appropriatetest_delete_with_groupingkey.send_responseafter the request is stored, instead of before.end_headersis required in the HTTP handler for Python 3.4.socket.connectthrows an error on Windows when using '0.0.0.0' or the empty string as the target host (although either seems to work fine on Linux). I therefore changed the tests to use 'localhost' as the target host instead. This does also affect theinstance_ip_grouping_keyfunction exposed in the client module, but from some quick testing on my Linux machine there seems to be no difference between the old and new way.Let me know if you have any questions or comments.