8000 Permit subclassing of MetricsHandler by jeanralphaviles · Pull Request #339 · prometheus/client_python · GitHub
[go: up one dir, main page]

Skip to content

Permit subclassing of MetricsHandler #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Permit subclassing of MetricsHandler #339

merged 1 commit into from
Nov 7, 2018

Conversation

jeanralphaviles
Copy link
Contributor

@brian-brazil

Changes MetricsHandler.factory from a staticmethod to a classmethod to be able to determine the correct subclass to return. This way if a user wants to extend the behavior of their MetricsHandler, they don't have to reimplement the factory() method.

Changes MetricsHandler.factory from a staticmethod to a classmethod to
be able to determine the correct subclass to return. This way if a user
wants to extend the behavior of their MetricsHandler, they don't have to
reimplement the factory() method.

Signed-off-by: Jean-Ralph Aviles <jeanralph.aviles@gmail.com>
@brian-brazil brian-brazil merged commit a50f3e4 into prometheus:master Nov 7, 2018
@brian-brazil
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0