Enable flake8 import lint checking #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Packman <martin@zegami.com>
Combine isort config into tox.ini and tweak the rules so that the standard flake8 import rules pass. Rerun isort to adjust a few of specific cases for new rules. Signed-off-by: Martin Packman <martin@zegami.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #325 by @akx has landed, the flake8 rules on import style lint can be enabled.
Combined the isort
setup.cfgintotox.iniand added a couple of extra config options so it passes the default flake8 rules.As it wasn't very obvious that there was existing lint tooling #326 updates
CONTRIBUTING.mdto point it out.