8000 Add detailed Garbage Collection statistics. by tcolgate · Pull Request #301 · prometheus/client_python · GitHub
[go: up one dir, main page]

Skip to content

Add detailed Garbage Collection statistics. #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

tcolgate
Copy link
Contributor

We've found this useful in monitoring pythons Garbage Collection. If you are
interested in including this:

  • Should the name default to python_gc perhaps?
  • Are you happy for these all to be histograms?
  • If so, how would you prefer the buckets to be set up (presumably defaulted and
    pass in to the constructor?)
  • I'm not actually sure if having uncollected as a histogram is of much use. Uncollected
    should be monitored, but histogram is probably overkill.
  • I'll fill out the tests?

Copy link
Contributor
@brian-brazil brian-brazil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python_gc would be typical.