Optimizations for tuples using. Removed unused types transformations. #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prometheus_client/core.py
Outdated
| labels = [] | ||
| self._labelnames = tuple(labels) | ||
|
|
||
| self._labelnames = tuple(labels or []) |
There was a problem hiding this comment.
What performance difference does this make?
There was a problem hiding this comment.
No difference, just more shorted and more Pythonyc.
If you prefer, I can remove this changes from PR.
There was a problem hiding this comment.
It's fine as-is, and I'd expect it to be faster this way
cdbbdbb to
a84ba47
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple optimizations of tuple using.