Reduce unnecessary metric creation in loop #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prometheus_client/multiprocess.py
Outdated
|
|
||
| metric = metrics.get(metric_name) | ||
| if metric is None: | ||
| metrics[metric_name] = metric = core.Metric(metric_name, 'Multiprocess metric', typ) |
There was a problem hiding this comment.
Chaining = can be confusing, can you make this two statements?
17c8202 to
350d24b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I will try to improve multiprocess metrics collections by a series of pull requests.
This one fixes unnecessary metric creation in loop.
The more correct way to use
dict.setdefaultisresult = dict.setdefault(key, value). In our case:instead of
But the problem is that
core.Metric(...)will be executed each time when setdefault method calls whether needed or not.