8000 PEP333 does not require QUERY_STRING to be present. by daroot · Pull Request #252 · prometheus/client_python · GitHub
[go: up one dir, main page]
Skip to content

PEP333 does not require QUERY_STRING to be present. #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2018
Merged

PEP333 does not require QUERY_STRING to be present. #252

merged 1 commit into from
Mar 6, 2018

Conversation

daroot
Copy link
Contributor
@daroot daroot commented Mar 6, 2018

Ensure that if a WSGI server does not provide the QUERY_STRING in the
environ, that we don't throw an exception and cause a 500 to be returned
to the scraping client.

@brian-brazil

PEP333 does not require QUERY_STRING to be present.
8ea5d64 
Ensure that if a WSGI server does not provide the QUERY_STRING in the
environ, that we don't throw an exception and cause a 500 to be returned
to the scraping client.
@brian-brazil brian-brazil merged commit 4ba6c90 into prometheus:master Mar 6, 2018
@brian-brazil
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daroot @brian-brazil
0