Set default timeout of pushgateway actions to 30s #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly passing `None` will still trigger the no timeout behaviour of the underlying Python http/socket modules.
brian-brazil
reviewed
Feb 5, 2018
prometheus_client/exposition.py
Outdated
| @@ -30,6 +30,11 @@ | |||
|
|
|||
| PYTHON26_OR_OLDER = sys.version_info < (2, 7) | |||
|
|
|||
| # Default socket timeout for http requests, such as to a pushgateway. | |||
| # Note: Setting this after import time will not change the default used. | |||
| _REQUEST_TIMEOUT = 30 | |||
There was a problem hiding this comment.
It's be simpler to hardcode it, this is more than enough time.
There was a problem hiding this comment.
Using a (pseudo) const is mostly a hint to use a consistent value for anything doing http requests. Can just use literal everywhere if you'd prefer?
As requested by @brian-brazil in review.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly passing
Nonewill still trigger the no timeout behaviour of the underlying Python http/socket modules.This is motived by hitting an odd case in a k8s cluster job where some job pods were hung for 2 hours in the finally-post-metrics step after some cluster unhappiness that had since been resolved. However, I couldn't later reproduce the behaviour locally, as my machine at least does timeout the socket after a reasonable window regardless.
Even so, was worth adapting our application code to set a timeout, and having a sensible default in the client library here also seems reasonable.