8000 multiprocess: pass None as default argument by dzen · Pull Request #212 · prometheus/client_python · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@dzen
Copy link
Contributor
@dzen dzen commented Nov 13, 2017

The goal here is to evaluate the environ only at parse time : I tried to mock the variable to make some unittests, but I hit those lines : I cannot patch the environ to fill a temp destination for that test

@brian-brazil any comment on this ?

The goal here is to evaluate the environ only at parse time
to allow to mock environment variables
@brian-brazil brian-brazil merged commit 3679aa2 into prometheus:master Nov 13, 2017
@brian-brazil
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0