8000 Test and support Python 3.6 by bz2 · Pull Request #181 · prometheus/client_python · GitHub
[go: up one dir, main page]

Skip to content

Test and support Python 3.6 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2017
Merged

Conversation

bz2
Copy link
Contributor
@bz2 bz2 commented Jul 31, 2017

Add py36 to the Travis CI config, and setup.py classifiers.

Also tweak local tox config, install twisted for 3.6 but make noptionals variant use 2.7 and 3.5 only.

tox.ini Outdated
@@ -1,5 +1,5 @@
[tox]
envlist = coverage-clean,py26,py27,py34,py35,py36,pypy,{py27,py35,py36}-nooptionals,coverage-report
envlist = coverage-clean,py26,py27,py34,py35,py36,pypy,{py27,py35}-nooptionals,coverage-report
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's test the noooptionals with 3.6 rather than 3.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing.

Add py36 to the Travis CI config, and setup.py classifiers.

Also tweak local tox config, install twisted for 3.6 and make
noptionals variant use 2.7 and 3.6 only, as suggested by
@brian-brazil in review.
@bz2
Copy link
Contributor Author
bz2 commented Jul 31, 2017

Okay, 9c07a12 has the nooptionals variant run for 2.7 and 3.6 only for both travis and tox.

@brian-brazil brian-brazil merged commit 96b91c3 into prometheus:master Jul 31, 2017
@brian-brazil
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0