8000 `write_to_textfile` leaves back temp files on errors · Issue #1044 · prometheus/client_python · GitHub
[go: up one dir, main page]
Skip to content

write_to_textfile leaves back temp files on errors #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
calestyo opened this issue Jul 4, 2024 · 2 comments · Fixed by #1066
Closed

write_to_textfile leaves back temp files on errors #1044

calestyo opened this issue Jul 4, 2024 · 2 comments · Fixed by #1066
Labels
bug

Comments

@calestyo
Copy link
calestyo commented Jul 4, 2024

Hey.

A simple:

prometheus_client.write_to_textfile("", registry=registry)

which causes an exception:

Traceback (most recent call last):
  File "/home/calestyo/prj/prometheus-smart-array-collector/src/./smart-array.py", line 1185, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/calestyo/prj/prometheus-smart-array-collector/src/./smart-array.py", line 1176, in main
    prometheus_client.write_to_textfile("", registry=registry)
  File "/usr/lib/python3/dist-packages/prometheus_client/exposition.py", line 363, in write_to_textfile
    os.rename(tmppath, path)
FileNotFoundError: [Errno 2] No such file or directory: '.969277.139657657282624' -> ''

shows that the module doesn't properly clean up it's temp files on errors, as that file is left over afterwards.

Cheers,
Chris.
@csmarchbanks
Copy link
Member

Seems reasonable to avoid leaving around tons of temporary files, though they will be cleaned up eventually. I'd be happy to accept a PR.

@ethanschen ethanschen mentioned this issue Oct 16, 2024
Merged
@ethanschen
Copy link
Contributor
ethanschen commented Oct 16, 2024 •
edited
Loading

PTAL #1066 @calestyo @csmarchbanks

csmarchbanks pushed a commit that referenced this issue Oct 25, 2024
@ethanschen
Fix write_to_textfile leaves back temp files on errors (#1044) (#1066)
c89624f 
Signed-off-by: Ethan S. Chen <ethanschen@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix write_to_textfile leaves back temp files on errors
3 participants
@calestyo @csmarchbanks @ethanschen
0