fix: add very small delay between observations in TestHistogramAtomicObserve
#1691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istic (and faster) Signed-off-by: Ivan Goncharov <i.morph@gmail.com>
5bc3947 to
9be1b8f
Compare
|
thank you for the fast fix! |
amberpixels
pushed a commit
to amberpixels/prometheus_client_golang
that referenced
this pull request
Nov 29, 2024
…istic (and faster) (prometheus#1691) Signed-off-by: Eugene <eugene@amberpixels.io>
This was referenced Feb 19, 2025
Merged
1 task
1 task
1 task
1 task
1 task
Merged
1 task
1 task
This was referenced Feb 19, 2025
Merged
1 task
This was referenced Feb 19, 2025
Update module github.com/prometheus/client_golang to v1.21.1 - autoclosed
giantswarm/exporterkit#147
Closed
Closed
1 task
This was referenced Aug 24, 2025
This was referenced Aug 29, 2025
Merged
Merged
1 task
1 task
1 task
This was referenced Sep 18, 2025
1 task
1 task
1 task
Merged
1 task
This was referenced Sep 26, 2025
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Test
TestHistogramAtomicObservetaking too long to complete after introducing this change:Analysis
@ywwg pointed out that increase for this test runtime were introduced after adding exponential back-off to histograms.
If we will take a look at this test closely we will see that observations here
introduced in a very high pace inside tight loop without any delay or limit.
waitForCooldownfunction in theWritemethod, as observations are delayed.Solution
Under typical workloads, contention is usually not as extreme as in this test. Observations has at least some delays between them. So proposal is to alter test by adding nanosecond sleep to it, which significantly reduce runtime and makes it a little bit closer to what happens typically in production.