fix: replace fmt.Errorf with errors.New #1689
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```shell
prometheus/process_collector_darwin.go:28:25: fmt.Errorf can be replaced with errors.New (perfsprint)
var notImplementedErr = fmt.Errorf("not implemented")
```
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
ArthurSens
approved these changes
Nov 19, 2024
amberpixels
pushed a commit
to amberpixels/prometheus_client_golang
that referenced
this pull request
Nov 29, 2024
```shell
prometheus/process_collector_darwin.go:28:25: fmt.Errorf can be replaced with errors.New (perfsprint)
var notImplementedErr = fmt.Errorf("not implemented")
```
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Eugene <eugene@amberpixels.io>
This was referenced Feb 19, 2025
Merged
1 task
1 task
1 task
1 task
1 task
Merged
1 task
1 task
This was referenced Feb 19, 2025
Merged
1 task
This was referenced Feb 19, 2025
Update module github.com/prometheus/client_golang to v1.21.1 - autoclosed
giantswarm/exporterkit#147
Closed
Closed
1 task
This was referenced Aug 24, 2025
This was referenced Aug 29, 2025
Merged
Merged
1 task
1 task
1 task
This was referenced Sep 18, 2025
1 task
1 task
1 task
Merged
1 task
This was referenced Sep 26, 2025
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prometheus/process_collector_darwin.go:28:25: fmt.Errorf can be replaced with errors.New (perfsprint) var notImplementedErr = fmt.Errorf("not implemented")Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com