Fix/setup fields #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Mainly a bug fix.
What is the current behavior?
Right now if you look at the PyPi homepage for the project and click on the homepage link on the left, you'll be directed to the old repository location within the
SMARTeacherorganization.Also notice that the description page on PyPI is blank. This does not give the user any clear information on what the project is about.
What is the new behavior?
Changing the url means that PyPi should now point to the new github repository that is public.
Following the guide Making a pypi friendly readme, the setup function now uses the README file as what to show in the project description on PyPi. Take a peek at the test pypi repository to see what the output looks like
Does this PR introduce a breaking change?
No breaking changes to the functionality of the project. Just fixes a bug with how the project looks on PyPi.
Other information
First Pull Request of the project 🎉