update minimum version of cmake now that version 3.5 of cmake has been deprecated#632
update minimum version of cmake now that version 3.5 of cmake has been deprecated#632NissimBendanan wants to merge 3 commits intoprobonopd:masterfrom
Conversation
update minimum version of cmake now that version 3.5 of cmake has been deprecated
Update CMakeLists.txt
|
Why would we ever want to do that? I think it is good that our software still builds using older build systems. |
|
this is the cmake config error with [cmake] CMake Error at vendor/github.com/probonopd/linuxdeployqt/CMakeLists.txt:4 (cmake_minimum_required): even after my change to update to the minimum version supported by cmake (currently 3.5), we don't get an error but a warning: [cmake] CMake Deprecation Warning at vendor/github.com/probonopd/linuxdeployqt/CMakeLists.txt:4 (cmake_minimum_required): So, the latest version of cmake 4.0.0. no longer supports versions earlier than 3.5 |
|
GitHub actions ubuntu runner was recently updated to include CMake version 4.0.0 - see https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20250330.1
You must decide whether to support legacy CMake versions or newer versions. The majority of developers will have a newer version of CMake installed. |
update minimum version of cmake to 3.10 - version < 3.5 have been deprecated - version < 3.10 will be next removed
|
Closing in favor of #633 |
No description provided.