8000 Added plantuml file preview feature by msr1k · Pull Request #169 · previm/previm · GitHub
[go: up one dir, main page]

Skip to content

Added plantuml file preview feature#169

Merged
mattn merged 2 commits intoprevim:masterfrom
msr1k:feature/add-plantuml-filetype-support
Jun 13, 2022
Merged

Added plantuml file preview feature#169
mattn merged 2 commits intoprevim:masterfrom
msr1k:feature/add-plantuml-filetype-support

Conversation

@msr1k
Copy link
Contributor
@msr1k msr1k commented Apr 1, 2022

Added plantuml filetype (*.puml) preview functionality in an easy-lazy way.
(It might need to install https://github.com/aklt/plantuml-syntax to make vim recognize plantuml filetype.)

If it's okay I will do the documents also if it's needed.

@msr1k
Copy link
Contributor Author
msr1k commented Apr 1, 2022

The way I created first seems not ideal If the target plantuml file has multiple @start... @end... blocks.
Then I separate them to be respectively converted to an image.

@mattn
Copy link
Member
mattn commented Jun 13, 2022

LGTM

@mattn mattn merged commit 774cf4f into previm:master Jun 13, 2022
@mattn
Copy link
Member
mattn commented Jun 13, 2022

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0