fix previm_wsl_mode for fish shell#140
Merged
mattn merged 1 commit intoprevim:masterfrom Jan 15, 2020
Merged
Conversation
mattn
reviewed
Jan 15, 2020
mattn
approved these changes
Jan 15, 2020
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#135 で追加された
previm_wsl_modeをfish shellから使用した場合に、:PrevimOpenをしてもpreviewをブラウザで開くことができなかったため修正しました。環境
原因
シェルで
{ブラウザの実行ファイルへのパス} '{ファイルパス}'を実行した場合に、shやbashとfishではファイルパスの解釈の仕方が違うようです。そのためfishから実行するとpreview用のファイルにアクセスできなくなっていました。
ex)
bash × Chrome
fish × Chrome
bash × Firefox
fish × Firefox
行ったこと
ファイルパスを渡す際にスキーム名まで明記することで、実行するシェルに関わらず正しく動くようにしました。
動作確認
この6通りの組み合わせで問題なく動くことを確認しました。