Fix the condition to judge as win & firefox environment.#109
Merged
mattn merged 2 commits intoprevim:masterfrom Oct 5, 2018
Merged
Fix the condition to judge as win & firefox environment.#109mattn merged 2 commits intoprevim:masterfrom
mattn merged 2 commits intoprevim:masterfrom
Conversation
|
It can be |
|
Checking multiple But actually |
Contributor
Author
|
Thanks for your comment. Modified version was attached. As far as read the help, It seems unnecessary also for 'win64unix'. But this patch did not fix it because it does not cause problems. |
|
Thanks for the fix!
Yes, maybe |
Member
|
Thank you. I'll fix the rest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added parentheses to the condition to judge as win & firefox.
Under the condition before modification, if I set chrome command in windows, previm judge as win & firefox. As a result, previm was trying to open an incorrect file path with chrome and got into file not found error.