8000 TypeScript: print JSDoc-only types by thorn0 · Pull Request #7020 · prettier/prettier · GitHub
[go: up one dir, main page]
Skip to content

TypeScript: print JSDoc-only types #7020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2019
Merged

TypeScript: print JSDoc-only types #7020

merged 2 commits into from
Nov 21, 2019

Conversation

thorn0
Copy link
Member
@thorn0 thorn0 commented Nov 20, 2019 •
edited
Loading

fixes #5840

It would be really easy to replace these types with valid TS, but so far we (with @evilebottnawi) decided to print them as is.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@thorn0 thorn0 merged commit 13d37da into prettier:master Nov 21, 2019
lipis added a commit that referenced this pull request Nov 26, 2019
@lipis
Merge branch 'master' of github.com:prettier/prettier into svgo
9ccde1b 
* 'master' of github.com:prettier/prettier: (51 commits)
  Bump @typescript-eslint/typescript-estree from 2.8.0 to 2.9.0 (#7054)
  Bump @babel/preset-react from 7.7.0 to 7.7.4 in /website (#7044)
  Bump @babel/preset-env from 7.7.1 to 7.7.4 in /website (#7045)
  Bump rollup from 1.27.3 to 1.27.5 (#7047)
  Bump @babel/parser from 7.7.3 to 7.7.4 (#7034)
  Bump @babel/preset-env from 7.7.1 to 7.7.4 (#7035)
  Bump resolve from 1.12.0 to 1.12.2 (#7032)
  fix formatting of logical and binary expressions in template literals (#7010)
  Bump docusaurus from 1.14.1 to 1.14.2 in /website (#7030)
  fix unstable formatting of logical expressions (#7026)
  Bump rollup from 1.27.2 to 1.27.3 (#7025)
  TypeScript: print JSDoc-only types (#7020)
  Bump docusaurus from 1.14.0 to 1.14.1 in /website (#7023)
  preserve parentheses for JSDoc type casting with extra spaces a… (#7011)
  Bump rollup from 1.26.3 to 1.27.2 (#7016)
  Ignore test files (#7018)
  Bump @typescript-eslint/typescript-estree from 2.7.0 to 2.8.0 (#7017)
  refactoring: tokens requested from TS parser were immediately dismissed (#7008)
  test: css-in-js (#7005)
  tests(handlebars): Move a test to handlebars folder (#6962)
  ...
@thorn0 thorn0 mentioned this pull request Jan 29, 2020
Merged
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
@thorn0 thorn0 deleted the jsdoc-only-types branch March 11, 2021 22:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lydell lydell lydell approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flow Maybe syntax makes TypeScript parser throw
4 participants
@thorn0 @lydell @alexander-akait @sosukesuzuki
0