8000 Improve `getPreferredQuote` by fisker · Pull Request #18366 · prettier/prettier · GitHub
[go: up one dir, main page]
Skip to content

Improve getPreferredQuote #18366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fisker merged 6 commits into from
Dec 1, 2025
Merged

Improve getPreferredQuote #18366

fisker merged 6 commits into from
Dec 1, 2025

Conversation

@fisker
Copy link
Member
@fisker fisker commented Nov 28, 2025 •
edited
Loading

Description

Thanks to @liuxingbaoyu for giving me the idea in #18351

getPreferredQuote (1 characters)
┌─────────┬───────────────┬──────────────────┬───────────────────┬────────────────────────┬────────────────────────┬─────────┐
│ (index) │ Task name     │ Latency avg (ns) │ Latency med (ns)  │ Throughput avg (ops/s) │ Throughput med (ops/s) │ Samples │
├─────────┼───────────────┼──────────────────┼───────────────────┼────────────────────────┼────────────────────────┼─────────┤
│ 0       │ 'Development' │ '195.53 ± 1.67%' │ '200.00 ± 100.00' │ '6648366 ± 0.04%'      │ '5000000 ± 1666667'    │ 5114208 │
│ 1       │ 'Production'  │ '142.62 ± 0.38%' │ '100.00 ± 0.00'   │ '8311393 ± 0.02%'      │ '10000000 ± 0'         │ 7011610 │
└─────────┴───────────────┴──────────────────┴───────────────────┴────────────────────────┴────────────────────────┴─────────┘
getPreferredQuote (10 characters)
┌─────────┬───────────────┬──────────────────┬──────────────────┬────────────────────────┬────────────────────────┬─────────┐
│ (index) │ Task name     │ Latency avg (ns) │ Latency med (ns) │ Throughput avg (ops/s) │ Throughput med (ops/s) │ Samples │
├─────────┼───────────────┼──────────────────┼──────────────────┼────────────────────────┼────────────────────────┼─────────┤
│ 0       │ 'Development' │ '169.67 ± 0.41%' │ '200.00 ± 0.00'  │ '6711767 ± 0.03%'      │ '5000000 ± 0'          │ 5893627 │
│ 1       │ 'Production'  │ '213.48 ± 6.09%' │ '200.00 ± 0.00'  │ '5169320 ± 0.02%'      │ '5000000 ± 0'          │ 4684215 │
└─────────┴───────────────┴──────────────────┴──────────────────┴────────────────────────┴────────────────────────┴─────────┘
getPreferredQuote (100 characters)
┌─────────┬───────────────┬──────────────────┬───────────────────┬────────────────────────┬────────────────────────┬─────────┐
│ (index) │ Task name     │ Latency avg (ns) │ Latency med (ns)  │ Throughput avg (ops/s) │ Throughput med (ops/s) │ Samples │
├─────────┼───────────────┼──────────────────┼───────────────────┼────────────────────────┼────────────────────────┼─────────┤
│ 0       │ 'Development' │ '465.85 ± 0.29%' │ '400.00 ± 0.00'   │ '2283858 ± 0.02%'      │ '2500000 ± 0'          │ 2146600 │
│ 1       │ 'Production'  │ '1082.4 ± 0.09%' │ '1100.0 ± 100.00' │ '938168 ± 0.02%'       │ '909091 ± 75758'       │ 923851  │
└─────────┴───────────────┴──────────────────┴───────────────────┴────────────────────────┴────────────────────────┴─────────┘
getPreferredQuote (1000 characters)
┌─────────┬───────────────┬──────────────────┬───────────────────┬────────────────────────┬────────────────────────┬─────────┐
│ (index) │ Task name     │ Latency avg (ns) │ Latency med (ns)  │ Throughput avg (ops/s) │ Throughput med (ops/s) │ Samples │
├─────────┼───────────────┼──────────────────┼───────────────────┼────────────────────────┼────────────────────────┼─────────┤
│ 0       │ 'Development' │ '3162.0 ± 0.10%' │ '3200.0 ± 100.00' │ '321853 ± 0.03%'       │ '312500 ± 9470'        │ 316253  │
│ 1       │ 'Production'  │ '10609 ± 0.07%'  │ '10600 ± 300.00'  │ '95010 ± 0.05%'        │ '94340 ± 2597'         │ 94261   │
└─────────┴───────────────┴──────────────────┴───────────────────┴────────────────────────┴────────────────────────┴─────────┘
getPreferredQuote (10000 characters)
┌─────────┬───────────────┬──────────────────┬───────────────────┬────────────────────────┬────────────────────────┬─────────┐
│ (index) │ Task name     │ Latency avg (ns) │ Latency med (ns)  │ Throughput avg (ops/s) │ Throughput med (ops/s) │ Samples │
├─────────┼───────────────┼──────────────────┼───────────────────┼────────────────────────┼────────────────────────┼─────────┤
│ 0       │ 'Development' │ '66217 ± 0.11%'  │ '66800 ± 1300.0'  │ '15167 ± 0.10%'        │ '14970 ± 297'          │ 15103   │
│ 1       │ 'Production'  │ '103741 ± 0.18%' │ '104300 ± 2900.0' │ '9712 ± 0.17%'         │ '9588 ± 259'           │ 9640    │
└─────────┴───────────────┴──────────────────┴───────────────────┴────────────────────────┴────────────────────────┴─────────┘
getPreferredQuote (100000 characters)
┌─────────┬───────────────┬───────────────────┬───────────────────┬────────────────────────┬────────────────────────┬─────────┐
│ (index) │ Task name     │ Latency avg (ns)  │ Latency med (ns)  │ Throughput avg (ops/s) │ Throughput med (ops/s) │ Samples │
├─────────┼───────────────┼───────────────────┼───────────────────┼───────
10000
────────────────┼────────────────────────┼─────────┤
│ 0       │ 'Development' │ '672748 ± 0.36%'  │ '680300 ± 21200'  │ '1494 ± 0.35%'         │ '1470 ± 47'            │ 1487    │
│ 1       │ 'Production'  │ '1023614 ± 0.54%' │ '1028200 ± 40300' │ '983 ± 0.47%'          │ '973 ± 37'             │ 977     │
└─────────┴───────────────┴───────────────────┴───────────────────┴────────────────────────┴────────────────────────┴─────────┘

Checklist

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory).
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

@pkg-pr-new
Copy link
pkg-pr-new bot commented Nov 28, 2025 •
edited
Loading

Open in StackBlitz

yarn add https://pkg.pr.new/prettier/prettier/@prettier/plugin-hermes@18366.tgz

yarn add https://pkg.pr.new/prettier/prettier/@prettier/plugin-oxc@18366.tgz

yarn add https://pkg.pr.new/prettier/prettier@18366.tgz

commit: 7b045f7

@netlify
Copy link
netlify bot commented Nov 28, 2025 •
edited
Loading

✅ Deploy Preview for prettier ready!

Name Link
🔨 Latest commit e5c0d64
🔍 Latest deploy log https://app.netlify.com/projects/prettier/deploys/692ce29b817d0b000805b732
😎 Deploy Preview https://deploy-preview-18366--prettier.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fisker fisker marked this pull request as ready for review November 28, 2025 22:25
@fisker fisker force-pushed the get-preferred-quote branch from 547bd2e to 7b045f7 Compare December 1, 2025 00:23
@fisker fisker merged commit 363a20e into prettier:main Dec 1, 2025
31 of 32 checks passed
@fisker fisker deleted the get-preferred-quote branch December 1, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fisker
0