Use new sass-parser for Sass parsing #17915
Conversation
* main: (140 commits) chore(deps): update dependency esbuild to v0.25.10 (prettier#17913) chore(deps): update dependency sdbm to v3 (prettier#17914) Prevent matching mixin calls inside arguments (prettier#17903) chore(deps): update dependency oxc-parser to v0.89.0 (prettier#17912) Improve emoji width measurement (prettier#17813) Unify `require()` and `import()` formatting logic (prettier#17902) Allow `parser.preprocess` to return a `Promise` (prettier#17679) Fix config file names order (prettier#17685) Fix format of comments around `ChainExpression` (prettier#17723) Cleanup cspell.json (2025-09-11) (prettier#17901) Add automated job to clean cspell.json yearly (prettier#17900) Add missing parentheses to arrow function in `TSInstantiationExpression` (prettier#17724) Increased level of self-documentation of code (prettier#17765) Fix crash on CSS custom properties (prettier#17899) doc: update related-projects.md (prettier#17804) docs: add monaco-prettier integration (prettier#17815) Build: stop transforming optional chaining (prettier#17863) Remove unnecessary path parameters (prettier#17867) chore(deps): update dependency nano-spawn to v1.0.3 (prettier#17898) chore(deps): update dependency knip to v5.63.1 (prettier#17896) ...
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Please don't change existing tests add this as a new css (sass) parser like we have for C7DC js/ts/etc |
@alexander-akait Can you help clarify to be sure I understand? My intention is that this would eventually replace the existing |
|
@alexander-akait Any feedback on my questions above? I'm happy to adjust this PR once I have a clearer sense for what you're requesting. Thanks! |
Description
See #17732.
This draft PR integrates
sass-parserinto Prettier for Sass parsing (and presumably could be expanded to include CSS parsing as well). For ease of initial testing, this first draft adds a newsassparserparsing language, and leaves the existingscssparser intact. Sass tests are modified to run against the new parser, so that test failures highlight formatting differences:There are currently a lot of test failures. Many of them should hopefully be resolved with fixes/additions to the underlying Sass parser, but some of them represent possible formatting improvements, and/or edge cases that still need to be addressed.
Todo
sass-parserisn't production-ready, and is still missing some critical features. Many of these are documented with// TODOcomments in the new parser, including:rawsdatadeclaration.importantthrows an errorconfigurationnodes are missingsource.span(throws an error)@extendnodes expose a parsedselector?@prettier-placeholder(see also Proposal: refactor css placeholder for TemplateLiteral #6790)Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.