Fix 17746 #17857
Open
Fix 17746 #17857
+253
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue where prettier was removing blank lines between list items and nested sublists in Markdown, which could change the semantic meaning of the content. The fix detects original blank lines in the source and preserves them when they occur before nested lists within list items. This addresses cases where users intentionally use blank lines to create visual separation or semantic grouping in their markdown lists. Fixes prettier#17746
Add changelog entry for the fix that preserves blank lines in nested markdown lists, addressing issue prettier#17746. This changelog documents the bug fix that ensures markdown formatting maintains proper spacing in nested list structures, improving output consistency with markdown standards.
commit: |
✅ Deploy Preview for prettier ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Why is this change needed? The test snapshots need to be updated to reflect the fix for issue prettier#17746, which preserves blank lines in nested markdown lists. The snapshots now correctly show blank lines between numbered list items and their nested sub-items. How does it address the issue? Updates the Jest snapshot file to match the corrected formatting behavior where blank lines are preserved in nested list structures, ensuring tests pass with the new formatting rules. What effects does the patch have? Test snapshots now accurately represent the expected markdown formatting output, ensuring that the markdown parser correctly maintains blank lines in nested list structures as intended by the fix.
Contributor
Author
|
I think https://github.com/prettier/prettier/actions/runs/17574300842/job/49916187236?pr=17857 will be passed when rerun the task. |
Contributor
|
The merge conflict with #18321 needs to be resolved. |
Contributor
|
@byplayer You have never got a review yet and PRs are squashed when merged, so you can either |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix of issue #17746.
Preserve blank lines in nested lists
Fixed an issue where prettier was removing blank lines between list items
and nested sublists in Markdown, which could change the semantic meaning
of the content. The fix detects original blank lines in the source and
preserves them when they occur before nested lists within list items.
This addresses cases where users intentionally use blank lines to create
visual separation or semantic grouping in their markdown lists.
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.