fix: Add simplified and traditional chinese as separate language options #169 #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4215e0 to
4172fca
Compare
Author
|
@surajbeston @ShivaRajBadu Removed the chinese language option changes since they are already merged in #179 . This PR now only modifies Cypress tests in UploadPage.cy.tsx to select and verify both "Chinese (Simplified - 中文, 汉语)" and "Chinese (Traditional - 中文, 漢語)" instead of the previous combined "Chinese "option. Feel free to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request splits the previous single Chinese language option into two distinct options for language selection throughout the presentation generator app:
Changes Made
LanguageTypeenum intype.tsto remove the combined Chinese option and add separate entries for Simplified and Traditional Chinese.UploadPage.cy.tsxto select and verify both "Chinese (Simplified - 中文, 汉语)" and "Chinese (Traditional - 中文, 漢語)" instead of the previous combined option.Motivation
Testing
Closes #169