8000 Update Rust toolchain by simolus3 · Pull Request #83 · powersync-ja/powersync-sqlite-core · GitHub
[go: up one dir, main page]

Skip to content

Update Rust toolchain #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2025
Merged

Update Rust toolchain #83

merged 4 commits into from
Jun 3, 2025

Conversation

simolus3
Copy link
Contributor
@simolus3 simolus3 commented Jun 2, 2025

This updates to a rustc nightly version that is more recent (2024-05-18 to 2025-04-15). #70 relies on features that have been added more recently.

This also fixes some compilation warnings, mainly about unused imports or parameters.

@simolus3 simolus3 marked this pull request as draft June 2, 2025 15:18
@simolus3
Copy link
Contributor Author
simolus3 commented Jun 3, 2025

The valgrind failures we're seeing when strip is enabled are likely due to a leak in Rust related to threading code. cargo-valgrind suppresses that particular leak automatically, but it can't do that when we strip the binary.

It looks like there's no good reason to keep the strip = true options on dev builds (or at least I can't see it). Everything that we build / release here is compiled in release mode. So stripping dev binaries by default only makes things harder for us.

@simolus3 simolus3 marked this pull request as ready for review June 3, 2025 07:39
@simolus3 simolus3 requested a review from rkistner June 3, 2025 07:39
@simolus3 simolus3 merged commit 8d83323 into main Jun 3, 2025
21 checks passed
@simolus3 simolus3 deleted the update-rust branch June 3, 2025 08:57
@simolus3 simolus3 mentioned this pull request Jun 11, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0