Use serde to read tables and indexes from schema #81
+260
−272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkistner
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the SDK passes a JSON-serialized schema to the core extension, that schema is mostly traversed using JSON functions in SQL. IMO, some of these are rather tricky to understand and enforce more complexity (e.g. with the streaming iterators to
json_object_fragment) than necessary.This refactors some of the queries to parse the schema using serde instead, which in some cases allows traversing it much easier. All the existing golden schema test pass, so this doesn't change behavior. Some of the queries which only need a subset of information from the schema are left unchanged for now.