Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkistner
previously approved these changes
May 30, 2025
rkistner
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm moving some independent parts out of #70 to make that easier to review and understand.
This adds a
Checksumnewtype wrapping au32, making the way we deal with checksum computations a little easier to understand:Checksumimplements the+and-operators modulo 2³². This is the behavior we want, and avoids issues if we forget awrapping_addorwrapping_subcall somewhere.u32types. We've previously been usingi32(which doesn't make a difference for addition and subtraction), but this makes it clearer that checksums are unsigned types that need to be explicitly cast fromi32where necessary.syncsubmodule.