Use uncommon key for canDefineProperty test

leebyron · leebyron · commit 1c9d970d3c5d · 2015-01-26T20:39:54.000-05:00
Some versions of Chrome have a bug where in some conditions, setting a property as non-enumerable can result in that property being non enumerable for all objects, as reported by immutable-js#295. As a work-around, we should be using a property name that is far less likely to be used as an enumerable property in the future.
diff --git a/dist/immutable.js b/dist/immutable.js
@@ -869,7 +869,7 @@
   // True if Object.defineProperty works as expected. IE8 fails this test.
   var canDefineProperty = (function() {
     try {
-      Object.defineProperty({}, 'x', {});
+      Object.defineProperty({}, '@', {});
       return true;
     } catch (e) {
       return false;
diff --git a/dist/immutable.min.js b/dist/immutable.min.js
diff --git a/src/Hash.js b/src/Hash.js
@@ -131,7 +131,7 @@ function hashJSObj(obj) {
 // True if Object.defineProperty works as expected. IE8 fails this test.
 var canDefineProperty = (function() {
   try {
-    Object.defineProperty({}, 'x', {});
+    Object.defineProperty({}, '@', {});
     return true;
   } catch (e) {
     return false;
