8000 Avoid making x properties non-enumerable by atalmadge · Pull Request #295 · immutable-js/immutable-js · GitHub
[go: up one dir, main page]
Skip to content

Avoid making x properties non-enumerable #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Avoid making x properties non-enumerable #295

wants to merge 1 commit into from

Conversation

atalmadge
Copy link

I'm seeing cases where Object.keys({x:1, y:2}) is yielding ['y'].

@atalmadge
Avoid making x properties non-enumerable
a9bf544 
I'm seeing cases where Object.keys({x:1, y:2}) is yielding ['y'].
leebyron added a commit that referenced this pull request Jan 27, 2015
@leebyron
Use uncommon key for canDefineProperty test
1c9d970 
Some versions of Chrome have a bug where in some conditions, setting a property as non-enumerable can result in that property being non enumerable for all objects, as reported by #295. As a work-around, we should be using a property name that is far less likely to be used as an enumerable property in the future.
@leebyron
Copy link
Collaborator

I changed the new key to "@" which is even less likely to cause conflict. Thanks again for digging into this.

@leebyron leebyron closed this Jan 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atalmadge @leebyron
0