10000 NodeApp is refactored by dmitry-lipetsk · Pull Request #278 · postgrespro/testgres · GitHub
[go: up one dir, main page]
Skip to content

NodeApp is refactored #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 30, 2025
Merged

NodeApp is refactored #278

merged 19 commits into from
Jun 30, 2025
+670 −189

Conversation

dmitry-lipetsk
Copy link
Collaborator
@dmitry-lipetsk dmitry-lipetsk commented Jun 27, 2025 •
edited
Loading

This patch contains a lot of improvements for NodeApp

Also

  • OsOperations::create_clone is added
  • PostgresNode::release_resources is added

Closes #277
Closes #267
Closes #265

@dmitry-lipetsk
NodeApp was moved to own py-file (refactoring)
17fb8c3
@dmitry-lipetsk
NodeApp is refactored totally
8eaa289
@dmitry-lipetsk
NodeApp::test_path is corrected
2246447
@dmitry-lipetsk
Default value of 'pg_options' (NodeApp::make_simple) is None
3fe3e94
@dmitry-lipetsk
Merge branch 'master' into D20250626_001--node_app
c1afd7e
@dmitry-lipetsk
OsOperations::create_clone is added
1062a97
@dmitry-lipetsk
[postgrespro#277] NodeApp::make_empty does not allow None/empty base_dir
1512fe7
@dmitry-lipetsk
[postgrespro#267] NodeApp.make_simple does not change 'initdb_params'
8000
b5b0d2b 
- method works with copy of initdb_params
- Default value of initdb_params is None
@dmitry-lipetsk
test_node_app__make_empty__base_dir_is_None is corrected
dffde2c
@dmitry-lipetsk
NodeApp::make_simple is corrected (bad assert)
d5c3672 
when checksum == True and initdb_params contains "--data-checksums", "assert final_initdb_params is not initdb_params" raised.
@dmitry-lipetsk
test_node_app__make_empty__base_dir_is_xxx is updated
aae53eb
@dmitry-lipetsk
[postgrespro#265] NodeApp.make_simple links a new node with own os_op…
488d556 
…s and port_manager objects
@dmitry-lipetsk
test_node_app__make_empty is corrected
688b89f
@dmitry-lipetsk
NodeApp::nodes_to_cleanup is RO-property
4f85ce5
@dmitry-lipetsk
flake8
f79e9a7
This was linked to issues Jun 27, 2025
NodeApp.make_empty must pass os_ops and port_manager to nodes #265
Closed
NodeApp.make_simple changes input parameter initdb_params #267
Closed
@dmitry-lipetsk
Copy link
Collaborator Author

Patch was tested with probackup2 and probackup3. All is OK.

@dmitry-lipetsk dmitry-lipetsk merged commit bbbec3e into postgrespro:master Jun 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dmitry-lipetsk
0