8000 [#274] Unused should_rm_dirs is deleted (cleanup) by dmitry-lipetsk · Pull Request #275 · postgrespro/testgres · GitHub
[go: up one dir, main page]
Skip to content

[#274] Unused should_rm_dirs is deleted (cleanup) #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

[#274] Unused should_rm_dirs is deleted (cleanup) #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[#274] Unused should_rm_dirs is deleted (cleanup) 
This strange PostgresNode property is not documented and is not used in Testgres code.
  • Loading branch information
@dmitry-lipetsk
dmitry-lipetsk committed Jun 25, 2025
commit 35a7b7ec4950cd3c2fafda55cc3fcdcd1e874412
4 changes: 0 additions & 4 deletions testgres/backup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,6 @@ def spawn_primary(self, name=None, destroy=True):
assert type(node) == self.original_node.__class__ # noqa: E721

with clean_on_error(node) as node:

# New nodes should always remove dir tree
node._should_rm_dirs = True

# Set a new port
node.append_conf(filename=PG_CONF_FILE, line='\n')
node.append_conf(filename=PG_CONF_FILE, port=node.port)
Expand Down
1 change: 0 additions & 1 deletion testgres/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2384,7 +2384,6 @@ def make_empty(
self.os_ops.makedirs(real_base_dir)

node = PostgresNode(base_dir=real_base_dir, port=port, bin_dir=bin_dir)
node.should_rm_dirs = True
self.nodes_to_cleanup.append(node)

return node
Expand Down
0