8000 PostgresNode::start is refactored by dmitry-lipetsk · Pull Request #174 · postgrespro/testgres · GitHub
[go: up one dir, main page]
Skip to content

PostgresNode::start is refactored #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2024
Merged

PostgresNode::start is refactored #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PostgresNode::start is refactored 
We do not translate a new node port into string when we pack it in new option dictionary.
  • Loading branch information
@dmitry-lipetsk
dmitry-lipetsk committed Dec 27, 2024
commit c6e6f1095c072b1828056a54e73054d2d9788f50
2 changes: 1 addition & 1 deletion testgres/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,7 @@ def LOCAL__raise_cannot_start_node__std(from_exception):
cur_port = self.port
new_port = utils.reserve_port() # can raise
try:
options = {'port': str(new_port)}
options = {'port': new_port}
self.set_auto_conf(options)
except: # noqa: E722
utils.release_port(new_port)
Expand Down
0