Normalize error

postgrespro · demonolock · Jul 4, 2024 · Jul 3, 2024 · Jul 3, 2024 · Jul 4, 2024
commit 0784f4961c335042d4bfdd3ea1626ae3b692a705
diff --git a/testgres/node.py b/testgres/node.py
@@ -1165,7 +1165,6 @@ def poll_query_until(self,
         assert sleep_time > 0
         attempts = 0
         while max_attempts == 0 or attempts < max_attempts:
-            logging.info(f"Pooling {attempts}")
             try:
                 res = self.execute(dbname=dbname,
                                    query=query,
@@ -1189,6 +1188,7 @@ def poll_query_until(self,
                     return    # done
 
             except tuple(suppress or []):
+                logging.info(f"Trying execute, attempt {attempts + 1}.\nQuery: {query}")
                 pass    # we're suppressing them
 
             time.sleep(sleep_time)

diff --git a/testgres/operations/remote_ops.py b/testgres/operations/remote_ops.py
@@ -93,8 +93,10 @@ def exec_command(self, cmd, wait_exit=False, verbose=False, expect_error=False,
         if not error:
             error_found = 0
         else:
+            error = normalize_error(error)
             error_found = exit_status != 0 or any(
-                marker in error for marker in [b'error', b'Permission denied', b'fatal', b'No such file or directory'])
+                marker in error for marker in ['error', 'Permission denied', 'fatal', 'No such file or directory']
+            )
 
         if error_found:
             if isinstance(error, bytes):
@@ -369,3 +371,9 @@ def db_connect(self, dbname, user, password=None, host="localhost", port=5432):
             password=password,
         )
         return conn
+
+
+def normalize_error(error):
+    if isinstance(error, bytes):
+        return error.decode()
+    return error
diff --git a/testgres/utils.py b/testgres/utils.py
@@ -3,7 +3,6 @@
 from __future__ import division
 from __future__ import print_function
 
-import logging
 import os
 
 import sys
@@ -229,7 +228,7 @@ def eprint(*args, **kwargs):
     """
     Print stuff to stderr.
     """
-    logging.error(*args, **kwargs)
+    print(*args, file=sys.stderr, **kwargs)
 
 
 def options_string(separator=u" ", **kwargs):